Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename LOTUS_USE_FVM_EXPERIMENTAL #8831

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Jun 9, 2022

Related Issues

Users have been failing to sync testnets using the FVM for v15 and earlier, which is not supported. It’s fine for mainnet v15, and obviously does nothing after v16, because everything uses FVM anyway.

Proposed Changes

We still want to be syncing mainnet using the FVM for our own testing purposes, so I propose renaming the variable.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner June 9, 2022 15:22
@jennijuju jennijuju merged commit 87d1e8d into release/v1.16.0 Jun 9, 2022
@jennijuju jennijuju deleted the arajasek-patch-2 branch June 9, 2022 21:42
@jennijuju
Copy link
Member

ah I should've not approved this pr

@jennijuju
Copy link
Member

#8837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants