Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: market: upgrade index-provider and related dependencies #8945

Merged
merged 7 commits into from
Jun 29, 2022

Conversation

arajasek
Copy link
Contributor

#8890, but with fixed up tests and rebased

Related Issues

Proposed Changes

Upgrade index-provider to the latest and upgrade all related dependencies, including go-fil-market upgrade.

Additional Info

There are a lot of dependencies update here, not all of which relate to index-provider. Please review carefully.

Current blocker for getting this PR ready for review is rolling out breaking changes of go-cid 0.2.0 across dependencies of Lotus.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner June 29, 2022 17:57
masih and others added 7 commits June 29, 2022 14:55
Upgrade required dependencies and fix breaking changes.
Upgrade to the latest go-fil-markets with dependency to go-blockstore
upgraded.
Address staticcheck issues caused by deprecated APIs and `go mod tidy`.
The quic transport implementation is now moved to `go-libp2p` mono repo.
Replace the dependency to the archived repo with the new one.

Regenerate CLI docs.
@arajasek arajasek force-pushed the asr/upgrade-idxprov branch from a7c68de to 0c34699 Compare June 29, 2022 18:55
Copy link
Contributor Author

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving @masih's PR (thanks Masih!)

@arajasek arajasek merged commit 68fc567 into master Jun 29, 2022
@arajasek arajasek deleted the asr/upgrade-idxprov branch June 29, 2022 19:10
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably isn't going to break anything.

require.NoError(t, err)
require.NoError(t, f.Close())
return f.Name()
return t.TempDir() + string(os.PathSeparator) + "tmp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants