-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: market: upgrade index-provider and related dependencies #8945
Conversation
Upgrade required dependencies and fix breaking changes.
Upgrade to the latest go-fil-markets with dependency to go-blockstore upgraded.
Address staticcheck issues caused by deprecated APIs and `go mod tidy`.
The quic transport implementation is now moved to `go-libp2p` mono repo. Replace the dependency to the archived repo with the new one. Regenerate CLI docs.
a7c68de
to
0c34699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving @masih's PR (thanks Masih!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably isn't going to break anything.
require.NoError(t, err) | ||
require.NoError(t, f.Close()) | ||
return f.Name() | ||
return t.TempDir() + string(os.PathSeparator) + "tmp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8890, but with fixed up tests and rebased
Related Issues
Proposed Changes
Upgrade
index-provider
to the latest and upgrade all related dependencies, includinggo-fil-market
upgrade.Additional Info
There are a lot of dependencies update here, not all of which relate to
index-provider
. Please review carefully.Current blocker for getting this PR ready for review is rolling out breaking changes of
go-cid
0.2.0
across dependencies of Lotus.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps