Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge: release v1.17.0 to master #9017

Merged
merged 1 commit into from
Jul 12, 2022
Merged

build: merge: release v1.17.0 to master #9017

merged 1 commit into from
Jul 12, 2022

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

Additional Info

(we will reset v1.17.0 code freeze from this master head after merge

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner July 11, 2022 23:12
@jennijuju jennijuju force-pushed the jen/v17merge branch 4 times, most recently from 28d1561 to 1baf9c5 Compare July 11, 2022 23:21
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #9017 (32f99e8) into master (e8230b5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9017      +/-   ##
==========================================
- Coverage   40.65%   40.64%   -0.02%     
==========================================
  Files         707      707              
  Lines       78729    78729              
==========================================
- Hits        32010    32002       -8     
- Misses      41253    41263      +10     
+ Partials     5466     5464       -2     
Impacted Files Coverage Δ
node/modules/storageminer.go 63.08% <ø> (ø)
storage/wdpost/wdpost_run_faults.go 46.89% <ø> (ø)
storage/wdpost/wdpost_sched.go 87.61% <100.00%> (+5.71%) ⬆️
markets/loggers/loggers.go 91.17% <0.00%> (-8.83%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/stmgr/call.go 70.05% <0.00%> (-3.39%) ⬇️
storage/sealer/sched.go 83.33% <0.00%> (-2.57%) ⬇️
storage/sealer/sched_assigner_common.go 78.40% <0.00%> (-2.28%) ⬇️
chain/events/events_called.go 88.29% <0.00%> (-1.96%) ⬇️
chain/actors/builtin/miner/miner.go 46.51% <0.00%> (-1.17%) ⬇️
... and 17 more

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho I'm a bit confused by why we don't have any v1.17 changelog here.

@jennijuju
Copy link
Member Author

LGTM, tho I'm a bit confused by why we don't have any v1.17 changelog here.

cuz c1.17.0 release is not final. this is just to merge everything existed for the release/v1.17.0 into master - so that we can reset the v1.17.0 code freeze , reason here and do a v1.17.0-rc3

@magik6k magik6k merged commit e7c8082 into master Jul 12, 2022
@magik6k magik6k deleted the jen/v17merge branch July 12, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants