Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing permissions tag #9461

Merged

Conversation

simlecode
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@simlecode simlecode requested a review from a team as a code owner October 10, 2022 08:57
@simlecode
Copy link
Contributor Author

I find a another problem, not include datacapkey: https://github.com/filecoin-project/lotus/blob/release/v1.18.0/chain/actors/builtin/registry.go#L84

@geoff-vball geoff-vball enabled auto-merge October 11, 2022 00:18
@geoff-vball geoff-vball disabled auto-merge October 11, 2022 14:25
@geoff-vball geoff-vball merged commit 59e80ae into filecoin-project:release/v1.18.0 Oct 11, 2022
@simlecode simlecode deleted the fix/missing-perm-tag branch October 12, 2022 00:55
@arajasek
Copy link
Contributor

@simlecode Thank you for the catch!

@geoff-vball
Copy link
Contributor

Thanks @simlecode for the other spot as well! PR to fix is up here #9476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants