Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use api.ErrActorNotFound instead of types.ErrActorNotFound & add fields to ForkUpgradeParams #9507

Merged

Conversation

simlecode
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@simlecode simlecode requested a review from a team as a code owner October 18, 2022 06:14
@magik6k
Copy link
Contributor

magik6k commented Oct 18, 2022

Can you add a note about this to https://github.com/filecoin-project/lotus/blob/master/documentation/misc/actors_version_checklist.md?

Also a better PR title would be welcome.

@simlecode simlecode changed the title fix: some issue fix: use api.ErrActorNotFound instead of types.ErrActorNotFound & add fields to ForkUpgradeParams Oct 19, 2022
@simlecode
Copy link
Contributor Author

Can you add a note about this to https://github.com/filecoin-project/lotus/blob/master/documentation/misc/actors_version_checklist.md?

Also a better PR title would be welcome.

I added a note to documentation/misc/actors_version_checklist.md

@arajasek arajasek merged commit 23f8bac into filecoin-project:release/v1.18.0 Oct 24, 2022
@simlecode simlecode deleted the fix/some-issue branch October 25, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants