api: ethrpc: fix eth_getCode, eth_getTransactionReceipt #9530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eth_getCode should take block options * eth_getTransactionReceipt should return null instead of an error when the tx is not found/not mined
raulk
approved these changes
Oct 21, 2022
| @@ -2343,7 +2343,8 @@ Perms: read | |||
| Inputs: | |||
| ```json | |||
| [ | |||
| "0x0707070707070707070707070707070707070707" | |||
| "0x0707070707070707070707070707070707070707", | |||
| "string value" | |||
There was a problem hiding this comment.
nit: we should create a specific type for this so we can validate the input and provide a more realistic example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#996
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps