Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth TX Encoding #9531

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Eth TX Encoding #9531

merged 2 commits into from
Oct 21, 2022

Conversation

Stebalien
Copy link
Member

This fixes several issues with Ethereum tx encoding:

  • Encode/decode tx params as CBOR (matching a similar change in the EVM).
  • Fix a bunch of issues with decoding contract deployment params/returns.

@Stebalien Stebalien requested a review from a team as a code owner October 21, 2022 07:28
@Stebalien Stebalien force-pushed the steb/cbor-encode-tx branch from 15b7b05 to 7b446dc Compare October 21, 2022 08:10
Also:

- Switch to methods from go-state-types
- Use the right method for contract creation
- Correctly handle decoding of contract creation returns
@raulk raulk merged commit 6286e33 into raulk/lisbon Oct 21, 2022
@raulk raulk deleted the steb/cbor-encode-tx branch October 21, 2022 10:59
vyzo pushed a commit that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants