test: verifreg: Test notaries cannot remove datacap from verifreg #9557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/remove-datacap-verifreg-test
branch
from
3522905 to
830b58c
Compare
arajasek
reviewed
Oct 28, 2022
7 tasks
geoff-vball
force-pushed
the
gstuart/remove-datacap-verifreg-test
branch
from
2a1d83c to
ec53587
Compare
|
@arajasek Plz check that the most recent commit seems right to you |
|
Yup, i think that's fine! |
arajasek
approved these changes
Oct 31, 2022
simlecode
reviewed
Nov 1, 2022
| if err != nil { | ||
| return nil, xerrors.Errorf("apply message failed: %w", err) | ||
| } | ||
| // Don't check for error here, we want to bubble it up, but also return ret as an InvocResult |
There was a problem hiding this comment.
ret may be nil？ @geoff-vball
There was a problem hiding this comment.
@simlecode you're right. I think this PR has the right behaviour #9582
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Tests the fix implemented here. Verifreg notaries should not be able to remove datacap from the verifreg actor, because the verifreg's datacap balance should always equal the datacap of all pending allocations.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps