feat:splitstore:single compaction that can handle prune aka two marksets one compaction #9571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Nov 2, 2022
magik6k
reviewed
Nov 4, 2022
magik6k
approved these changes
Nov 7, 2022
Comment on lines
-1299
to
1342
| func (s *SplitStore) deadSetPath() string { | ||
| func (s *SplitStore) discardSetPath() string { | ||
| return filepath.Join(s.path, "deadset") |
There was a problem hiding this comment.
Just sanity checking - we're not un-renaming the function because deadSet is now not quite what it used to mean?
There was a problem hiding this comment.
Yeah it now has a use in compaction not just prune and this is better suited to that domain.
arajasek
approved these changes
Nov 7, 2022
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Discussion kicked off here: #9128
Proposed Changes
Prune mode is now just a 3rd mode next to
discardanduniversal. There is only ever one compaction running so no need to add 3 new knobs to splitstore config.Additional Info
A quick conversation with @TippyFlitsUK supports the hypothesis that this minimal configuration strategy is a better all around approach.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps