feat: ethereum filters over indexed events #9646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
force-pushed
the
feat/nv18-events-historic
branch
from
f8209c9 to
73655ed
Compare
raulk
reviewed
Nov 15, 2022
iand
changed the base branch from
feat/nv18-events
to
raulk/events-integrate-fvm
iand
changed the base branch from
raulk/events-integrate-fvm
to
feat/nv18-events
iand
force-pushed
the
feat/nv18-events-historic
branch
from
02460a9 to
1035711
Compare
iand
changed the title
raulk
reviewed
Nov 15, 2022
Comment on lines
+250
to
+252
| // collect filter results | ||
| res, err := client.EthGetFilterChanges(ctx, filterID) | ||
| require.NoError(err) |
There was a problem hiding this comment.
We should assert on the data returned.
itests/fevm_events_test.go
Outdated
Comment on lines
47
to
62
| // var ( | ||
| // earliest = "earliest" | ||
| // latest = "latest" | ||
| // ) | ||
| // | ||
| // // Install a filter. | ||
| // filter, err := client.EthNewFilter(ctx, &api.EthFilterSpec{ | ||
| // FromBlock: &earliest, | ||
| // ToBlock: &latest, | ||
| // }) | ||
| // require.NoError(err) | ||
| // | ||
| // // No logs yet. | ||
| // res, err := client.EthGetFilterLogs(ctx, filter) | ||
| // require.NoError(err) | ||
| // require.Empty(res.NewLogs) |
There was a problem hiding this comment.
@iand are you planning to add itests for EthGetLogs and EthSubscribe?
raulk
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates all changes from #9644 and adds the capability to maintain Sqlite index of actor events that can be queried via the Eth api functions
From #9644
This PR connects the Lotus-side implementation of events with the FVM, by integrating these branches:
ref-fvm: https://github.com/filecoin-project/ref-fvm/tree/raulk/events
EVM actor: https://github.com/filecoin-project/builtin-actors/tree/raulk/events
filecoin-ffi: https://github.com/filecoin-project/filecoin-ffi/tree/raulk/events
A few schema changes were necessary.
We now display emitted events in the chain/invoke-evm-actor command.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps