_build_: Fix issues with new goreleaser flow #9684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goreleaser checks to make sure we don't have a dirty git state when releasing, which means the kubo download we use to set up IPFS should be removed before release.
Without this name, it assumes all binaries share the name of the project (i.e. lotus), which causes them all to get renamed and collide when generating the archive.
This will give us much more detailed information in the release job, so we can more easily debug issues when they occur.
geoff-vball
approved these changes
Nov 18, 2022
7 tasks
|
Backport here #9685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
The 1.19.0-rc1 release had a host of minor issues that happened because of some differences between the environment I tested stuff in and CircleCI.
https://app.circleci.com/pipelines/github/filecoin-project/lotus/24401/workflows/bcfbd26f-aebf-41d0-bb48-426f14d12111
Proposed Changes
This is a series of small fixes:
filecoin-goreleaser-keyCircleCI context, which has the GORELEASER_KEY env variable set (necessary for using the pro version of goreleaser). I also set this in the project env vars, but the context is a more reliable place to find the key, since it's used organization wide./tmp/workspace, but forgot to update one of the scripts which was using the old directory. This is now fixed.--debugflag with goreleaser so we get more verbose output in CI to more easily diagnose issues.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps