feat: fvm: add support for looking up past tipset CIDs #9687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Nov 19, 2022
Stebalien
force-pushed
the
feat/fevm-tipset-cid
branch
from
302308a to
93c2c10
Compare
|
@arajasek I've rebased on master, merge when ready. Note: this updates the FFI. Technically, we can get away with not doing that on master if you're so inclined. |
|
Actually, I'm just going to revert that part. |
Stebalien
force-pushed
the
feat/fevm-tipset-cid
branch
2 times, most recently
from
f577166 to
2e5cfb2
Compare
Stebalien
commented
Nov 19, 2022
| @@ -98,6 +99,28 @@ func (k *TipSetKey) UnmarshalJSON(b []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (k TipSetKey) Cid() (cid.Cid, error) { | |||
There was a problem hiding this comment.
@arajasek cherry-picked from feat/nv18-fevm. Please review.
(cherry-picked from feat/nv18-fevm)
We do this by adding yet another "getter" to the VM that resolves an epoch into a TipSetKey.
arajasek
force-pushed
the
feat/fevm-tipset-cid
branch
from
2e5cfb2 to
2bc1abc
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by adding yet another "getter" to the VM that resolves an epoch into a TipSetKey.
Alternatively, we could stick this functionality on
Rand, but then it wouldn't really be "rand" but something else...Depends on filecoin-project/filecoin-ffi#339
Merge plan:
Unfortunately, it needs to land on master because it bubbles a breaking change in the FFI (where the FVM now needs the ability to lookup tipset CIDs).
Alternatively, we could make this optional with a runtime type assertion. That is, if we find that we're using "v3" inside the FFI, we could type-assert that the "externs" supports the
TipsetCidmethod. That would let us merge the FFI changes without making any changes to the interface.