feat: sched: Cache worker calls #9737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/cache-sched-worker-calls
branch
4 times, most recently
from
329116a to
fb3e9a6
Compare
7 tasks
magik6k
force-pushed
the
feat/cache-sched-worker-calls
branch
from
fb3e9a6 to
dee3de9
Compare
geoff-vball
approved these changes
Nov 29, 2022
storage/sealer/sched_test.go
Outdated
Comment on lines
591
to
602
| func (s slowishSelector) Ok(ctx context.Context, task sealtasks.TaskType, spt abi.RegisteredSealProof, a SchedWorker) (bool, bool, error) { | ||
| _, _ = a.Paths(ctx) | ||
| _, _ = a.TaskTypes(ctx) | ||
| return bool(s), false, nil | ||
| } | ||
|
|
||
| func (s slowishSelector) Cmp(ctx context.Context, task sealtasks.TaskType, a, b *WorkerHandle) (bool, error) { | ||
| time.Sleep(100 * time.Microsecond) | ||
| func (s slowishSelector) Cmp(ctx context.Context, task sealtasks.TaskType, a, b SchedWorker) (bool, error) { | ||
| _, _ = a.Paths(ctx) |
There was a problem hiding this comment.
Can you leave a comment here as to why you're ignoring the outputs of the function calls?
Comment on lines
68
to
72
| partDone := metrics.Timer(sh.mctx, metrics.SchedAssignerCandidatesDuration) | ||
| defer func() { | ||
| partDone() | ||
| }() |
There was a problem hiding this comment.
Can you leave a comment here saying that this defer is meant to call the latest value of partDone in case we error out somewhere.
magik6k
force-pushed
the
feat/cache-sched-worker-calls
branch
from
dee3de9 to
2fd7550
Compare
magik6k
force-pushed
the
feat/cache-sched-worker-calls
branch
from
2fd7550 to
1597e85
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Based on on #9738
Proposed Changes
I've re-read the scheduler code today, and realized that all calls to workers in the scheduling loop are perfectly cachable. This PR adds some caching in the scheduling loop, theoretically reducing the number of workers calls in a scheduling cycle from
tasksToSchedule*candidateOpenWindowstounique(candidateOpenWindows.Worker)Additional Info
Benchmark on 400 deep queue with 200 workers (tldr ~700x faster when network roundtrips are ~100us)
Before:
After:
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps