Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make docsgen-cli use python3 #9773

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Dec 2, 2022

Related Issues

make docsgen-cli was failing on mac

Proposed Changes

changing Makefile to explicitly call python3

Additional Info

we're discussing rewriting ./scripts/generate-lotus-cli.py into go to not require python. However since we already are compatible with python3 and python 2 is not supported anymore, the explicit change to python3 is good. Simialrly once we rewrite generate lotus cli in GO, it's not bad that we've accepted this change, we can then still rip out python, but in the meantime having it supported on more. machines is good.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner December 2, 2022 17:48
@magik6k magik6k merged commit a4c999a into master Dec 5, 2022
@magik6k magik6k deleted the snissn/fix/make-docsgen-cli branch December 5, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants