Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_ Remove lotus soup + testplans #9802

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

ianconsolata
Copy link
Contributor

Related Issues

Discussion with Anton: https://filecoinproject.slack.com/archives/CP50PPW2X/p1670336395297749

The trigger-testplans job has been failing for the last month, because the testground-as-a-service endpoint we use no longer exists. While we could run testground ourselves, conversations with @nonsense seem to indicate that the things it covers are currently being tested by our itest suite, and therefore unnecessary. If we do want to re-enable testground, we should likely rebuild the testground infrastructure and test cases using a more recent version of testground, and lotus-soup can be resurrected from the git history at that point to serve as a basis for that work.

Proposed Changes

This removes the trigger-testplans job, the build-lotus-soup job that was used to create the triggered testplans, and the build-debug job which seems to be building a debug network but not using it for anything, or persisting the artifacts anywhere.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner December 6, 2022 15:33
@shrenujbansal shrenujbansal merged commit b491734 into master Dec 6, 2022
@shrenujbansal shrenujbansal deleted the id/remove-lotus-soup-testplans branch December 6, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants