Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependencies on api #9870

Closed

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Dec 14, 2022

Related Issues

Closes #9825

Proposed Changes

Moves a bunch of stuff around so that packages that shouldn't depend on api don't have to anymore.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner December 14, 2022 05:11
@geoff-vball geoff-vball changed the base branch from master to feat/nv18-fevm December 14, 2022 05:11
@geoff-vball geoff-vball force-pushed the gstuart/dont-depend-on-api-refactor branch from 42e8d9c to 667aa52 Compare December 14, 2022 06:36
@geoff-vball geoff-vball force-pushed the gstuart/dont-depend-on-api-refactor branch from 667aa52 to b5f126a Compare December 14, 2022 06:54
@arajasek
Copy link
Contributor

@geoff-vball Thanks for this! I need to think a bit more about whether we want to move things like HeadChange etc. into the core consensus types. It's a tradeoff between severing odd dependencies on API types vs. bloating the core consensus types.

How doable would it be to land just the last commit? That's the one I'm keenest on, because the only change urgently needed (blocking v18) IMO is having the core chain validation (state computation) path run through API types.

@geoff-vball geoff-vball marked this pull request as draft December 14, 2022 16:58
@geoff-vball
Copy link
Contributor Author

Might get to these changes later. For now, just making minimal changes in #9872

@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Move "core" Eth types from api to types
3 participants