Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove workaround that is no longer needed #9995

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Closes #9053

Proposed Changes

Removed workaround. The issue was fixed by golang v1.18.6
Now that we're building using 1.18.8 as the minimum version, the workaround is no longer needed.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 12, 2023 17:52
@magik6k magik6k merged commit 287d410 into master Jan 12, 2023
@magik6k magik6k deleted the gstuart/remove-workaround branch January 12, 2023 20:01
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
@rjan90 rjan90 mentioned this pull request Mar 20, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkPrecommit() errors on ARM machines.
3 participants