v2: Change SDK::send's params to take new type IpldBlock #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v2 #1199 +/- ##
==============================================
- Coverage 52.04% 51.31% -0.74%
==============================================
Files 124 126 +2
Lines 10101 10243 +142
==============================================
- Hits 5257 5256 -1
- Misses 4844 4987 +143
|
arajasek
force-pushed
the
asr/ipld-block-v2
branch
2 times, most recently
from
1f93f9b to
1c8a858
Compare
This was referenced Dec 5, 2022
IpldBlock supports multiple codecs, including IPLD_RAW. Serializing byte vectors will correctly serialize anything that serializes to "raw bytes". However, it _won't_ serialize "byte lists", so `Vec<u8>` and `[u8]` won't work. But that shouldn't be an issue in practice. Users _should_ serialize to/from `ByteBuf`.
arajasek
force-pushed
the
asr/ipld-block-v2
branch
from
1c8a858 to
3fc2662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpldBlock supports multiple codecs, including IPLD_RAW.
Serializing byte vectors will correctly serialize anything that serializes to "raw bytes". However, it won't serialize "byte lists", so
Vec<u8>and[u8]won't work. But that shouldn't be an issue in practice.Users should serialize to/from
ByteBuf.