This repository has been archived by the owner on May 5, 2023. It is now read-only.
fix: switch to using *mut ptrs, to indicate ownership #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
changed the title
8 tasks
Stebalien
approved these changes
Mar 18, 2022
vmx
suggested changes
Mar 21, 2022
| @@ -72,13 +72,13 @@ pub fn drop_struct_macro_derive(input: TokenStream) -> TokenStream { | |||
| // A list of fields that should get dropped | |||
| let mut to_be_dropped = Vec::new(); | |||
|
|
|||
| // Only take *const pointers into account (also not *mut) | |||
| // Only take *mut pointers into account (also not *mut) | |||
There was a problem hiding this comment.
I guess that should then say "also not *const".
|
closing, moving to a world where filecoin-ffi doesn't use this crate anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.