This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Remove SysErrInternal definition, use of which is always a bug #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Apr 20, 2020
| @@ -92,9 +92,7 @@ const ( | |||
| SysErrorReserved3 = ExitCode(12) | |||
| SysErrorReserved4 = ExitCode(13) | |||
| SysErrorReserved5 = ExitCode(14) | |||
|
|
|||
| // Indicates something broken within the VM. | |||
| SysErrInternal = ExitCode(15) | |||
There was a problem hiding this comment.
I'd keep the definition, maybe rename to something indicating it's a VM error
There was a problem hiding this comment.
The problem is that this can never safely be used. These exit codes go on chain, but every time there's a VM error of this form (idiosyncratic, not reproducible between impls) it should not go on chain; instead the state evaluation should just fail.
It should never have existed. If Lotus still uses it, they are all bugs that should either be a different exit code, or a "fatal" error.
arajasek
approved these changes
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of interop efforts last time round. Everywhere this was being used was incorrect (usually because the state transition should fail to be evaluated, rather than have this exist code persist on chain).