This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Change WPoStPartitionSectors to 2349 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
approved these changes
Apr 28, 2020
magik6k
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this change is required to match a number hardcoded in in rust-fil-proofs. Without this change, I'm pretty sure proofs will fail to validate since the wrong sector information will be passed.
The linked code is alarming in a few ways:
2for 512GiB sectors, which doesn't seem motivated by any technical reason but is pretty unworkable for practical networks.cc @dignifiedquire @porcuquine