DeadlineInfo handles expired proving period #343
Conversation
| func (d *DeadlineInfo) PeriodStarted() bool { | ||
| return d.CurrentEpoch >= d.PeriodStart | ||
| } | ||
|
|
||
| // Whether the proving period has elapsed. | ||
| func (d *DeadlineInfo) PeriodElapsed() bool { |
There was a problem hiding this comment.
If this returns true from ComputeProvingPeriodDeadline(minerStateFor(ts).periodStart, ts.Height()) in PoSt scheduling logic, am I supposed to abort, should the code just abort, or is there anything smarter it can do?
There was a problem hiding this comment.
I think aborting is pretty much it. You probably just have to wait for cron, and if the cron doesn't happen any proof will be rejected anyway.
Possibly you could compute the next period start that you know cron will set it to in order to eagerly begin, but I don't think that complexity is warranted at the moment.
|
FYI @acruikshank we probably need a similar check in go-filecoin. |
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 37.72% 37.82% +0.09%
==========================================
Files 40 40
Lines 4156 4172 +16
==========================================
+ Hits 1568 1578 +10
- Misses 2359 2363 +4
- Partials 229 231 +2 |
This provides a
PeriodElapsed()predicate and fixes the other ones to indicate that no challenge window is open after a proving period has elapsed and before the proving period start has been updated to the next period.Also changes assertions from using a too-high deadline index into errors.