This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Fix failure to detect faults of exactly-full top partition #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
commented
May 6, 2020
| firstSector := i * partitionSize | ||
| sectorCount := partitionSize | ||
| if i == partitionCount-1 { | ||
| sectorCount = dlSectorCount % partitionSize |
There was a problem hiding this comment.
This was wrong if the final partition was exactly full.
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 37.59% 37.60% +0.01%
==========================================
Files 40 40
Lines 4142 4140 -2
==========================================
Hits 1557 1557
+ Misses 2363 2361 -2
Partials 222 222 |
magik6k
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this while looking for the "failed to load fault sectors" error you observed. I don't think this fixes that problem, though.