Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stm annotations/增加STM注解 #103

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Sep 26, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#5316

改动 (Proposed Changes)

主要目的:
增加venus-wallet STM annotation.
实际修改:

  • 补充venus-wallet的部分测试用例
  • 小重构
    • ServeRPC函数, 可以从外部传入signal channel, 可以通过外部发送停止信号.
    • 移除了自定义jwt.HMACSHA类型的别名:common.APIAlg. 因为这是一个没有意义的重定义, 还容易导致循环引用.
  • venus-wallet添加STM的注解

💁‍♂️ :有部分重构是在编写测试用例的时候才发现需要重构的, 实在不太好单独拆分成不同的commit, 所以, 在commit上混到一起了.

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #103 (af43bc0) into master (f1d92dc) will increase coverage by 14.92%.
The diff coverage is 37.57%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #103       +/-   ##
===========================================
+ Coverage   13.18%   28.11%   +14.92%     
===========================================
  Files          46       48        +2     
  Lines        3936     4091      +155     
===========================================
+ Hits          519     1150      +631     
+ Misses       3328     2741      -587     
- Partials       89      200      +111     
Flag Coverage Δ
unittests 28.11% <37.57%> (+14.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/daemon.go 0.00% <0.00%> (ø)
cmd/mock/main.go 0.00% <0.00%> (ø)
filemgr/jwt.go 65.38% <ø> (ø)
integration_test/convert.go 24.39% <24.39%> (ø)
cmd/rpc.go 53.16% <25.00%> (+53.16%) ⬆️
integration_test/builder.go 49.29% <49.29%> (ø)
build/builder.go 89.39% <100.00%> (+89.39%) ⬆️
common/api_common.go 55.00% <100.00%> (+55.00%) ⬆️
filemgr/fs.go 58.46% <100.00%> (+24.61%) ⬆️
storage/strategy/strategy.go 4.72% <0.00%> (+4.72%) ⬆️
... and 22 more

@zl03jsj zl03jsj force-pushed the feat/zl/add-STM-annotations branch from 1c46467 to 6e55a6d Compare September 26, 2022 02:22
integration_test/builder.go Outdated Show resolved Hide resolved
integration_test/builder.go Outdated Show resolved Hide resolved
integration_test/integration_test.go Outdated Show resolved Hide resolved
integration_test/integration_test.go Outdated Show resolved Hide resolved
@zl03jsj zl03jsj self-assigned this Sep 26, 2022
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@zl03jsj zl03jsj merged commit 2839136 into master Sep 26, 2022
@zl03jsj zl03jsj deleted the feat/zl/add-STM-annotations branch September 26, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

venus-wallet 添加增加STM annotation
4 participants