Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: venus-shared: add util for parsing message #5145

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Jul 28, 2022

关联的Issues (Related Issues)

close #5143, 是 #5085 的子任务, 为 #5146 的前置任务.
在处理此任务后需要更新 go mod, 然后重新提交.

改动 (Proposed Changes)

在venus-share中, 增加消息解析的util.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #5145 (924d8cb) into master (977b92e) will increase coverage by 0%.
The diff coverage is 70%.

❗ Current head 924d8cb differs from pull request most recent head 736cbaf. Consider uploading reports for the commit 736cbaf to get more accurate results

@@          Coverage Diff           @@
##           master   #5145   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         595     596    +1     
  Lines       65482   65521   +39     
======================================
+ Hits        16524   16553   +29     
- Misses      46803   46810    +7     
- Partials     2155    2158    +3     

@zl03jsj zl03jsj force-pushed the feat/util-for-parsing-message branch from 924d8cb to 736cbaf Compare July 28, 2022 09:39
@zl03jsj zl03jsj force-pushed the feat/util-for-parsing-message branch from 736cbaf to f9dfe2f Compare July 28, 2022 10:06
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@simlecode simlecode merged commit f5a4cc0 into master Jul 29, 2022
@simlecode simlecode deleted the feat/util-for-parsing-message branch July 29, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-shared] 在venus-share中添加message paser的实现.
3 participants