Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: 各组件增加Version接口/add Version api for components #5150

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Aug 2, 2022

关联的Issues (Related Issues)

resolve #5132

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #5150 (3bc3e6d) into master (f5a4cc0) will decrease coverage by 0%.
The diff coverage is 12%.

@@          Coverage Diff           @@
##           master   #5150   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         596     597    +1     
  Lines       65521   65586   +65     
======================================
- Hits        16543   16542    -1     
- Misses      46816   46880   +64     
- Partials     2162    2164    +2     

@simlecode simlecode marked this pull request as draft August 2, 2022 07:35
@simlecode simlecode marked this pull request as ready for review August 3, 2022 03:17
@simlecode simlecode requested a review from hunjixin August 3, 2022 03:17
@simlecode simlecode changed the title api: add Version api for components api: 给组件增加Version接口/add Version api for components Aug 3, 2022
@simlecode simlecode changed the title api: 给组件增加Version接口/add Version api for components api: 各组件增加Version接口/add Version api for components Aug 3, 2022
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit 14d26a4 into master Aug 3, 2022
@hunjixin hunjixin deleted the api/add_Version branch August 3, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Venus] 各组件增加 Version 接口
3 participants