-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unit tests and STM annotations for chain module. #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5434 +/- ##
=======================================
+ Coverage 24% 26% +1%
=======================================
Files 605 605
Lines 67861 67864 +3
=======================================
+ Hits 16924 17693 +769
+ Misses 48750 47913 -837
- Partials 2187 2258 +71 |
zl03jsj
force-pushed
the
feat/adding-stm-anotations
branch
2 times, most recently
from
November 9, 2022 05:52
44609c2
to
a6e70b3
Compare
zl03jsj
force-pushed
the
feat/adding-stm-anotations
branch
from
November 11, 2022 03:38
244c502
to
2d4c716
Compare
…s deprecated and was replaced by unused.
zl03jsj
force-pushed
the
feat/adding-stm-anotations
branch
from
November 11, 2022 05:13
2d4c716
to
196e90d
Compare
simlecode
reviewed
Nov 11, 2022
simlecode
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+LGTM
LinZexiao
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
closes #5421
改动 (Proposed Changes)
feat: unit tests and STM annotations for chain module.
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: