feat: convert synthentic status codes to errors #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map synthetic status codes like 801 to string error codes i like HOSTNAME_DNS_ERROR to make the retrieval results easier to understand. Signed-off-by: Miroslav Bajtoš <[email protected]>
juliangruber
approved these changes
Jul 10, 2024
| case 901: return 'UNSUPPORTED_CID_HASH_ALGO' | ||
| case 902: return 'CONTENT_VERIFICATION_FAILED' | ||
| case 903: return 'UNEXPECTED_CAR_BLOCK' | ||
| case 904: return 'CANNOT_PARSE_CAR_FILE' |
There was a problem hiding this comment.
would be nice to move these status code to a shared node module eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map synthetic status codes like
801to string error codes likeHOSTNAME_DNS_ERRORto make the retrieval results easier to understand.Links: