Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deterministic task assignment #296

Merged
merged 10 commits into from
Jul 31, 2024
Merged

feat: deterministic task assignment #296

merged 10 commits into from
Jul 31, 2024

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jul 30, 2024

  • feat!: rename INVALID_TASK to TASK_NOT_IN_ROUND
  • feat: add startEpoch to RoundDetails type
  • feat: add DRAND client
  • feat: deterministic task assignment

For each station id, calculate the list of tasks assigned to this station by our deterministic task assignment algorithm. Reject measurements for other tasks.

The pull request may be easier to review commit-by-commit.

Links:

bajtos added 4 commits July 30, 2024 13:54
Signed-off-by: Miroslav Bajtoš <[email protected]>
For each station id, calculate the list of tasks assigned to this
station by our deterministic task assignment algorithm.

Reject measurements for other tasks.
@bajtos bajtos requested a review from juliangruber July 30, 2024 12:13
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

test/evaluate.js Outdated Show resolved Hide resolved
lib/tasker.js Show resolved Hide resolved
lib/tasker.js Show resolved Hide resolved
lib/tasker.js Outdated Show resolved Hide resolved
lib/evaluate.js Show resolved Hide resolved
Co-authored-by: Julian Gruber <[email protected]>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

fireworks

@juliangruber
Copy link
Member

Looks like unit tests are failing

@bajtos
Copy link
Member Author

bajtos commented Jul 31, 2024

I'll take a look.

I also need to manually resolve the merge conflict with #298.

@bajtos
Copy link
Member Author

bajtos commented Jul 31, 2024

Yeah, the integration test was failing because of a logical conflict with #298.

@bajtos bajtos enabled auto-merge (squash) July 31, 2024 14:26
@bajtos bajtos merged commit 44ac2b0 into main Jul 31, 2024
5 checks passed
@bajtos bajtos deleted the feat-deterministic-tasking branch July 31, 2024 14:27
Copy link

sentry-io bot commented Aug 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: fetch failed getRandomnessForSparkRound(drand-client) View Issue

Did you find this useful? React with a 👍 or 👎

@bajtos
Copy link
Member Author

bajtos commented Aug 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: fetch failed getRandomnessForSparkRound(drand-client) View Issue

Did you find this useful? React with a 👍 or 👎

See #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants