Add implementation. Closes #1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
commented
May 26, 2023
bajtos
requested changes
May 30, 2023
There was a problem hiding this comment.
NOICE! 💪🏻
I have a few suggestions for making the implementation and tests more robust.
Can you please set up a CI step to check formatting and lint errors? We can use standard or maybe just prettier with no-semicolons in the config plus eslint.
Please document this in the README too, so that contributors like me know how to check and fix formatting & listing errors 🙏🏻
bajtos
reviewed
May 31, 2023
bajtos
approved these changes
May 31, 2023
bajtos
reviewed
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1