feat: limit max download size + calculate SHA-256 checksum #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
commented
Oct 3, 2023
bajtos
commented
Oct 3, 2023
bajtos
commented
Oct 3, 2023
Signed-off-by: Miroslav Bajtoš <[email protected]>
* success -> healthy * remove `success` * update test
|
@juliangruber I merged your PR. Is there anything else to change here? |
juliangruber
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit introduces a limit of 200 MB on the amount of data we are willing to download. See #16
The second commit computes SHA-256 hash of the downloaded content and submits it in measurements. See #30
The measurements data submitted to SPARK API has two new fields:
carTooLargeindicating whether we downloaded all content or aborted in the middlecarChecksumcontaining a multihash of the content