Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: honour maxTasksPerRound from spark-api #47

Merged
merged 5 commits into from
Dec 13, 2023
Merged

feat: honour maxTasksPerRound from spark-api #47

merged 5 commits into from
Dec 13, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Dec 12, 2023 •
edited
Loading

@bajtos bajtos requested a review from juliangruber December 12, 2023 12:19
@bajtos
fixup! code cleanup
f9242c7 
Signed-off-by: Miroslav Bajtoš <[email protected]>
juliangruber
juliangruber requested changes Dec 12, 2023
View reviewed changes
lib/spark.js Show resolved Hide resolved
lib/spark.js Show resolved Hide resolved
juliangruber
juliangruber reviewed Dec 12, 2023
View reviewed changes
lib/spark.js Outdated Show resolved Hide resolved
juliangruber
juliangruber requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once maxTasksPerRound is fixed and this has been tested manually

@bajtos
Copy link
Member Author

bajtos commented Dec 13, 2023

I added another console log to give us visibility into the delay, and fixed the typo.

❯ zinnia run main.js
Getting current SPARK round details...
[10:25:17.699  INFO] SPARK started reporting retrievals
Current SPARK round: { roundId: "3876" }
  60 max tasks per node
  4000 retrieval tasks
(...)
Measurement submitted (id: 331077071)
[10:25:20.356 STATS] Jobs completed: 1
Sleeping for 57 seconds before starting the next task...

@bajtos bajtos requested a review from juliangruber December 13, 2023 09:27
@bajtos
fixup! npx standard --fix
a5c3396 
Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos merged commit 8e7cc85 into main Dec 13, 2023
1 check passed
@bajtos bajtos deleted the max-tasks-per-round branch December 13, 2023 09:35
@juliangruber
Copy link
Member

+1

@bajtos bajtos mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber Awaiting requested review from juliangruber

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajtos @juliangruber