Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icons load faster #5822

Closed
Josh65-2201 opened this issue Aug 14, 2021 · 9 comments · Fixed by #6427
Closed

Make icons load faster #5822

Josh65-2201 opened this issue Aug 14, 2021 · 9 comments · Fixed by #6427
Assignees

Comments

@Josh65-2201
Copy link
Member

What's the Problem?

Currently loading files and folders icons is slow but in file explorer it quick.

Solution/Idea

I believe windows has a caching system for the icons. Files should use this if it can.

Alternatives

Make your own caching system.

Priorities

No response

Files Version

1.9.23

Windows Version

10.0.19043.1151

Additional comment

No response

@winston-de
Copy link
Contributor

I believe windows has a caching system for the icons. Files should use this if it can.

Files already uses the windows apis for thumbnails, which includes using the thumbnail cache.

@Josh65-2201
Copy link
Member Author

Josh65-2201 commented Aug 14, 2021

Doesn't seem to work as it loads the icon one by one but windows file explorer is quite instant unless it's a new folder. Is there a way to speed it up?

@JoshKasap
Copy link

I don't think image caching is the issue. The reason windows explorer seems instant to you is that it's all you've ever used hence most files have had a thumbnail cached in the past. From my observations, it seems to load thumbnails as fast as windows explorer.

That said there is definitely some slowdown when compared to windows explorer when it comes to general folder navigation. I visit a folder (even one that has already cached) there is roughly a 1 second loading time before files show and another second wait before I can interact with the files shown.

There are some scenarios where navigation is instant but the above scenario seems to happen a lot whereas on windows explorer it tends to be instant.

@Josh65-2201
Copy link
Member Author

I used files a lot more than file explorer. But even with the same directory's it slower than file explorer sometimes. In small directory's its not that bad but bigger ones it does get slow.

files

2021-08-17.10-37-02.mp4

file explorer

2021-08-17.10-40-49.mp4

@gave92
Copy link
Member

gave92 commented Aug 17, 2021

Perhaps we could try showing the generic icon for folders and a cached icon based on file type for files instead of the monochrome icons, until the icon from explorer is loaded.

@lukeblevins
Copy link
Contributor

@yaichenbaum Based on our discussion from a while back, is it preferable to do what @gave92 suggested or leverage elements from the standard GridView placeholder behavior seen when scrolling through a virtualized data source? Or was this only intended for file items?

Personally, I don't see the harm of displaying an identical standard folder icon.

@yaira2
Copy link
Member

yaira2 commented Sep 9, 2021

@yaichenbaum Based on our discussion from a while back, is it preferable to do what @gave92 suggested or leverage elements from the standard GridView placeholder behavior seen when scrolling through a virtualized data source? Or was this only intended for file items?

Personally, I don't see the harm of displaying an identical standard folder icon.

How would that affect the support for displaying custom thumbnails?

@lukeblevins
Copy link
Contributor

@yaichenbaum The generic icon, if I understand correctly, would be displayed while the actual folder icon is being loaded.

@yaira2
Copy link
Member

yaira2 commented Sep 9, 2021

@yaichenbaum The generic icon, if I understand correctly, would be displayed while the actual folder icon is being loaded.

That should work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants