-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of watcher, operations and props loading #6028
Conversation
Wonderful Effect! |
@gave92 Improvements I planned to do have done. This PR is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Probably also closes #5822 |
It doesn't seem to load thumbnails much faster. |
@hez2010 great work! |
@yaichenbaum This PR somehow makes icon loading higher priority than extended props loading, so it does contribute to #5822 |
Details of Changes
File creation is usually a combination of creation (creating a file handle) and modification (writing initial content), given that
UpdateFileOrFolderAsync
is slow, we introduced performance regression unexpectedly in #5992. This PR also aims to resolve the performance issue ofUpdateFileOrFolderAsync
:Contributes to #4180
Validation
How did you test these changes?
Screenshots (optional)
Before:
before.mp4
before.mp4
After:
after.mp4
after.mp4