Code Quality: Improved app theme mode handler #13490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you fill this section out? |
|
Done |
0x5bfa
changed the title
|
@yaira2 This is ready for review. |
yaira2
reviewed
Oct 22, 2023
| /// <summary> | ||
| /// Provides static helper for switching and restoring app theme settings. | ||
| /// </summary> | ||
| public static class AppThemeHelper |
There was a problem hiding this comment.
Can this be simplified to ThemeHelper?
There was a problem hiding this comment.
Actually, looks like that was already the name.
yaira2
reviewed
Oct 22, 2023
| /// <summary> | ||
| /// Gets or sets a value for the app theme mode. | ||
| /// </summary> | ||
| String AppThemeMode { get; set; } |
There was a problem hiding this comment.
Suggested change
| String AppThemeMode { get; set; } | |
| String AppTheme { get; set; } |
I think we can remove the "Mode" part.
yaira2
reviewed
Oct 22, 2023
| section.IsExpanded = Ioc.Default.GetRequiredService<SettingsViewModel>().Get(section.Text == "SidebarFavorites".GetLocalizedResource(), $"section:{section.Text.Replace('\\', '_')}"); | ||
| var key = $"section:{section.Text.Replace('\\', '_')}"; | ||
|
|
||
| section.IsExpanded = ApplicationData.Current.LocalSettings.Values.Get(key, section.Text == "SidebarFavorites".GetLocalizedResource()); |
There was a problem hiding this comment.
It's out of scope for this PR, but there is some room for further improvements in this area. Ideally this would be saved to settings.json like everything eles.
yaira2
reviewed
Oct 22, 2023
| @@ -35,6 +35,13 @@ public bool UseCompactStyles | |||
| set => Set(value); | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public String AppThemeMode | |||
There was a problem hiding this comment.
Suggested change
| public String AppThemeMode | |
| public String AppTheme |
yaira2
changed the title
yaira2
force-pushed
the
main
branch
4 times, most recently
from
3ebb408 to
eea0fb2
Compare
0x5bfa
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During removing SettingsViewModel, I had to alter ThemeHelper since that ViewModel contained theme change event handler. And while I changing ThemeHelper, I noticed there were several visual issues therefore I fixed in this PR.
Task Checklist
Known Issues
Following issues would be fixed in the upcoming PR.
N/A
PR Checklist
Steps To Validate Changes
Screenshots
Footnotes
If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩
If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do, instead. ↩