Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP! #3610

Closed
wants to merge 7 commits into from
Closed

FTP! #3610

wants to merge 7 commits into from

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Feb 18, 2021

Built-in FTP support

This PR aims to add support to FTP and FTPs.

Closes #1342

TODO

  • Auto detect TLS/SSL settings - must
  • Enumeration and navigation - must
  • Path bar integration - must
  • Network credentials support
    • Ask credentials before connecting - must
    • Remember network credentials - better to have
    • Windows hello integration - not goal
  • Filesystem operations:
    • Copy and paste (akas. download and upload) - must
    • Delete and rename - must
    • Move and cut - better to have
  • Properties integration: statistics, owner, hash (if server supports), and permissions - better to have
  • Cache integration - better to have
  • Background transfer even when files is closed - better to have
  • Enumeration and file operations abstract layer for better maintainability - not goal
  • SFTP - not goal

@d2dyno1
Copy link
Member

d2dyno1 commented Feb 18, 2021

Closes #1342

@hez2010
Copy link
Member Author

hez2010 commented Feb 18, 2021

Closes #1342
Closes #2407

It only closes #1342, SFTP is a protocol over SSH which is completely different from FTP.

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 10, 2021

How's progress going?

@hez2010
Copy link
Member Author

hez2010 commented Mar 11, 2021

How's progress going?

Just don't have too much time on it recently. I'm planning to implement remaining things next week.

@yaira2
Copy link
Member

yaira2 commented Mar 11, 2021

@hez2010 Thanks for the update! If it's ready in the next couple of weeks, we should be able to include it in the next update.

@hez2010
Copy link
Member Author

hez2010 commented Mar 18, 2021

@yaichenbaum Do you think I should close this PR for now? I may push some unfinished work, which will trigger unnecessary CI.
I can reopen the PR once it's ready for review.

@yaira2
Copy link
Member

yaira2 commented Mar 18, 2021

@hez2010 I don't think the pipeline runs on draft PRs.

@hez2010
Copy link
Member Author

hez2010 commented Apr 4, 2021

I want to split this PR into two PRs. One is to remove IStorageItemWithPath and use IStorageItem for all cases (contributes to #4180, so operations to a file itself (Remove, Rename, and GetBasicProperties) could be implemented by just class XxxStorageItem : IStorageItem), and we can determine the type of a file and operate it by getting its implementation type instead of reviewing the path with lots of helper methods. Another one is to implement FTP after the previous one done.

Therefore, I'm closing this PR for now.

@d2dyno1
Copy link
Member

d2dyno1 commented Apr 4, 2021

Looking forward to removal of IStorageItemWithPath!

@hez2010 hez2010 closed this Apr 4, 2021
@yaira2
Copy link
Member

yaira2 commented Apr 5, 2021

@hez2010 Thanks for the update!

@hez2010 hez2010 mentioned this pull request Jul 30, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTP Support
3 participants