Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when resizing the sidebar too quickly #4998

Merged
merged 1 commit into from
May 23, 2021
Merged

Fix crash when resizing the sidebar too quickly #4998

merged 1 commit into from
May 23, 2021

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented May 23, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixed a crash when resizing the sidebar too quickly to the left. The crash was caused by passing a negative pixel value to the GridLength constructor, which in turn would throw an invalid argument exception.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

yaira2
yaira2 approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 23, 2021
@yaira2 yaira2 merged commit b22c0aa into main May 23, 2021
@yaira2 yaira2 deleted the SidebarResizeCrash branch May 23, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winston-de @yaira2