When there is no uri validation, do not validate the scheme #384
Conversation
|
Thanks for the PR! Would it be possible to simply deprecate the |
|
The PR is updated, introducing the policy as requested. |
| if (uri == null | ||
| || uri.length() < 3 // minimal form s(1):ssp(1) | ||
| public static final boolean isAbsoluteUri(final String uri, final UriValidationPolicy policy) { | ||
| boolean result = false; |
There was a problem hiding this comment.
The validation status could be returned directly, i.e., by returning true or false without assigning the result to a variable. However, I'm not going to block this PR because of it.
| * Method allowing to convert the legacy boolean to the matching policy | ||
| */ | ||
| public static UriValidationPolicy of(boolean value) { | ||
| if(value) |
There was a problem hiding this comment.
To align with the code conventions used in the rest of the codebase, please use {} or the inline construct return _ ? _ : _ ;. Thank you!
|
I addressed the feedbacks, thanks for the help :) |
Fixes #383
The
RdfDatasetcontains the invalid uri even if the scheme is wrong/missing if uri validation is disabled.