Enable and fix multiple lints for consistency #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
misc/add-lints-for-consistency
branch
from
f12b9b3 to
ba94ea9
Compare
|
Sweet! The PR is still marked as WIP, so I'll wait. I also assume there are no true semantic changes so I don't plan to review line-by-line. If there are some changes I should have a look at, please direct me to those files. |
|
No semantic changes, just a few minor name changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed over a few years where common practices have changed and by a few contributors, the style of the code is a bit inconsistent. As I work on more changes, I wanted to have a well-defined style to follow to allow reviewing to be easier and future code to be more consistent.
This PR adds a few lints and fixes them, mostly automatically, but with a few hand made changes as well.
If you prefer other options, like specifying types or using
var, let me know. I'm happy to make changes :)