Easier External Repo Definitions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Making BUILD file content strings public (removing leading `_`) in `deps.bzl`. * Adding `_CONTENT` suffix to variable names to be more clear and match the repo attribute name. * Wrapping dependency `http_archive` definitions with `maybe()`. This is to more easily allow downstream projects to define the dependency targets (bats-core, etc) with slightly changed attributes if they want/need to. Changing `urls` or adding `patches`, etc, can be done less verbosely by reusing BUILD file contents defined here. Applying changes can be done to only the necessary repos, others can still be loaded via `bazel_bats_dependencies()`.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_) indeps.bzl._CONTENTsuffix to variable names to be more clear and match the repo attribute name.http_archivedefinitions withmaybe().This is to more easily allow downstream projects to define the dependency targets (bats-core, etc) with slightly changed attributes if they want/need to.
Changing
urlsor addingpatches, etc, can be done less verbosely by reusing BUILD file contents defined here. Applying changes can be done to only the necessary repos, others can still be loaded viabazel_bats_dependencies().