Skip to content

Commit

Permalink
Add shard not owned error (cadence-workflow#6233)
Browse files Browse the repository at this point in the history
What changed?

Added a new error type returned from matching, TaskListNotOwnedByHostError in thrift and proto IDLs
We do not log errors on this error as it's an expected transient error
Why?

We have to propagate the error type over the wire so we can check the error type on the history side, to be able to handle it gracefully.
We should not have error logs on this error as it is expected and transient.
How did you test it?

Unit tests
Deployment in staging environment
Potential risks

Release notes

Documentation Changes
  • Loading branch information
jakobht authored Aug 27, 2024
1 parent 824676f commit 6ba8ad8
Show file tree
Hide file tree
Showing 23 changed files with 1,913 additions and 98 deletions.
663 changes: 660 additions & 3 deletions .gen/go/history/history.go

Large diffs are not rendered by default.

464 changes: 438 additions & 26 deletions .gen/go/matching/matching.go

Large diffs are not rendered by default.

332 changes: 330 additions & 2 deletions .gen/go/shared/shared.go

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions .gen/go/shared/types_yarpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6ba8ad8

Please sign in to comment.