removed package-lock.json from git cache and added it to gitignore #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@VikasShashidhar @lneir Please review. CC: @pmonks @bluechips23 |
|
Observed on #205 (comment) |
|
Manually deleting |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With package-lock.json baked into the repo, if we've made any updates to the package.json file, users running on npm > 5 is experiencing an issue (not really a bug, but a behaviour problem) where in the dependencies are being pulled from the package-lock.json with package.json deemed useless.
Solution
Since we are primarily using package.json while creating builds on Jenkins, I've removed the package-lock.json from git cache and added it to the ignore list.
Once we establish a process of using package-lock.json and npm > 5, we can add it back to the git list.
PS: An alternative is -> https://codeburst.io/disabling-package-lock-json-6be662f5b97d