Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TB] No introdcution page for Components in the right scrollable menu #889

Closed
omesh-omg opened this issue May 16, 2024 · 3 comments
Closed

[TB] No introdcution page for Components in the right scrollable menu #889

omesh-omg opened this issue May 16, 2024 · 3 comments
Assignees
@omesh-omg
Labels
theme builder app Theme Builder application

Comments

@omesh-omg
Copy link
Contributor

image

Suggestion

to add Introduction page for components in right scrollable menu as it is for atoms, molecules, organisms

Proposed Solution

Adding it on the top of right scrollable menu in the components page

image
@aaronreed708 aaronreed708 added the theme builder app Theme Builder application label May 16, 2024
@aaronreed708
Copy link
Contributor

makes sense to me

omesh-omg added a commit to omesh-omg/a11y-theme-builder that referenced this issue May 17, 2024
@omesh-omg
finos#889: added introduction of Components
7873697
This was referenced May 17, 2024
Closed
Merged
@omesh-omg
Copy link
Contributor Author

Hey @aaronreed708 I have linked the PR to resolve the issue I think everything is okay from my end.
Wanted to know your suggestion on the introduction description mostly.

omesh-omg added a commit to omesh-omg/a11y-theme-builder that referenced this issue May 20, 2024
@omesh-omg
adding-normalize.css issue finos#889
27882a7
@omesh-omg omesh-omg mentioned this issue May 20, 2024
Closed
aaronreed708 added a commit that referenced this issue May 22, 2024
@aaronreed708
Merge pull request #892 from omesh-omg/adding-introduction-components…
4326fd1 
…-#889

#889: added introduction of Components
@omesh-omg
Copy link
Contributor Author

This issue is resolved ready to close it @aaronreed708.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omesh-omg omesh-omg

Labels
theme builder app Theme Builder application
Projects
ThemeBuilder
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronreed708 @omesh-omg