Viewer Config Versioning, Migrations, and X/Y Scatter Serialization Updates #2401
+1,403
−792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada-x64
force-pushed
the
bugs/xy-scatter-symbol-serialization
branch
from
0b713a8 to
4b4159e
Compare
ada-x64
changed the title
|
|
ada-x64
force-pushed
the
bugs/xy-scatter-symbol-serialization
branch
from
4b4159e to
38de641
Compare
Co-authored-by: Tom Jakubowski <[email protected]> Co-authored-by: Broch Stilley <[email protected]>
Co-authored-by: Tom Jakubowski <[email protected]> Co-authored-by: Broch Stilley <[email protected]>
ada-x64
force-pushed
the
bugs/xy-scatter-symbol-serialization
branch
from
38de641 to
c5541fc
Compare
Update X/Y Scatter symbols serialization Fix X/Y Scatter padding issues
ada-x64
force-pushed
the
bugs/xy-scatter-symbol-serialization
branch
from
c5541fc to
cb34c31
Compare
ada-x64
commented
Nov 9, 2023
|
|
||
| import { cmp_semver, parse_semver } from "../migrate"; | ||
| /** | ||
| * Migrates to 1.0.0 |
There was a problem hiding this comment.
I'm still not entirely certain if this is the right versioning schema. We may want to link API versions to Perspective releases instead of decoupling them like this.
There was a problem hiding this comment.
Definitely use the Perspective version.
fix datagrid boolean click bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2399.
This PR adds versioning to the viewer configuration API. In particular, I've implemented a semver-style versioning system. Everything up to this point has been version "0.0.0" of the API. The semver allows build-style extensions a la cargo so we can, in the future, add a more nuanced migration tool to chain migrations from previous versions of perspective, e.g. from
0.0.0+1.5.0, where the build extension denotes the perspective version. I would also like to see backwards compatibility in the future, i.e. migrating existing viewer configs by directly importing them into the viewer.This PR updates migration scripts to include the new expression API and the new X/Y scatter plot plugin symboi serialization.
string[]to{name: string, expr: string}[]{key: string, value: string}to{[x: string]: string}