Fix scroll panel height calculation bug #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
scroll-panel-height
branch
from
1b11086 to
d453b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perspective's virtual scroll panels use a size-hint system to create the panels geometry without rendering or measuring all children (of which there may be thousands). However, these values have bitrotted. This PR fixes the hints to reflect the current geometry, but also adds a validation step to log in debug mode when the hints are incorrect.
I don't think this is worth an complex sizing/scroll system like
regular-tablehas, but it woul dbe nice to be able to specif these hard-coded geometry values in custom CSS rules at least.Before:
After:
