Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expressions format default #2438

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update expressions format default #2438

merged 2 commits into from
Nov 20, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Nov 17, 2023 •
edited
Loading

This PR fixes an omnibus of issues with this release's refactoring of the expressions config.

  • Updates all tests, examples and docs to use new format.
  • Fixes lots of formatting issues not enforced by the linter (especially in the html! macro).
  • Adds log warnings when the legacy expressions format is detected.
  • Fixes Python to have the same behavior.defaults as JavaScript.
  • Fixes CI Python script to not install perspective-python from pypi.

@texodus texodus added the bug Concrete, reproducible bugs label Nov 17, 2023
@texodus texodus changed the title Fix new expression format in Python Update expressions format default Nov 20, 2023
@texodus texodus force-pushed the python-expressions branch 2 times, most recently from 62b4bc4 to 11d0be6 Compare November 20, 2023 04:22
@texodus texodus merged commit 7c2ac9d into master Nov 20, 2023
12 checks passed
@texodus texodus deleted the python-expressions branch November 20, 2023 05:17
@texodus texodus mentioned this pull request Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@texodus