Move Column Settings from Plugin to Viewer with Column Settings Layout API #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada-x64
force-pushed
the
features/plugin-layout-api
branch
2 times, most recently
from
19f10e6 to
ab36413
Compare
ada-x64
commented
Feb 12, 2024
| const converted = convert(JSON.parse(JSON.stringify(old)), { | ||
| replace_defaults: true, | ||
| verbose: true, | ||
| }); | ||
| expect(converted).toEqual(current); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| test.describe("migrate", async () => { |
There was a problem hiding this comment.
Previously this tested that 1) the migration script did what was expected and that 2) the viewer restored to the expected value. This caused a lot of noise when debugging, so the test has been reconfigured to only test 2) since we test 1) above.
ada-x64
force-pushed
the
features/plugin-layout-api
branch
from
ab36413 to
d5ab6c7
Compare
ada-x64
force-pushed
the
features/plugin-layout-api
branch
from
d5ab6c7 to
e927bd9
Compare
ada-x64
force-pushed
the
features/plugin-layout-api
branch
2 times, most recently
from
f9dff51 to
49178d0
Compare
integrate can_render_column_styles to viewer
initial datagrid integration
fix datagrid tests symbols integration
update migrations Co-authored-by: Davis Silverman <[email protected]> Co-authored-by: Broch Stilley <[email protected]>
better column_config update repr
ada-x64
force-pushed
the
features/plugin-layout-api
branch
from
49178d0 to
6e2fe6b
Compare
|
Thanks for the PR! Superseded by #2563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2500; merges #2502 for SVG testing support
This PR aims to create a control-based API for column settings, bringing column-based settings from plugin configs to the viewer. This will allow us to support column settings which persist across plugins, e.g. numeric precision.
The design intends to allow plugin authors to use a number of viewer-defined "style controls." These style controls will affect column_config settings per row. This PR only changes the plugin API and maintains the existing style controls on the datagrid and x/y scatter chart. Following PRs will break up the current monolithic and type-based controls into more fine-grained and reusable controls.
Changes:
plugin.pluginAttributesplugin.column_style_controls(type, group)plugin.column_style_controlsplugin.restore(plugin_config, column_config)Notes:
restorethe best option for updating the plugins? We could also userestyle.