Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist: include data_dir again #2852

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,12 @@ jobs:
- name: Verify licenses are installed
shell: bash
run: |
pip show -f perspective-python > wheel_installed_files.txt
grep licenses/LICENSE.md wheel_installed_files.txt
grep licenses/LICENSE_THIRDPARTY_cargo.yml wheel_installed_files.txt
pip show -f perspective-python | tee wheel_installed_files.txt
# Maturin got this wrong: the packages should be in .dist-info/licenses/
# Newer versions of Maturin will fix it, so search for either location.
# https://github.com/PyO3/maturin/pull/862 https://github.com/PyO3/maturin/pull/2181
grep -E '.dist-info/(license|license_files)/LICENSE.md' wheel_installed_files.txt
grep -E '.dist-info/(license|license_files)/LICENSE_THIRDPARTY_cargo.yml' wheel_installed_files.txt

- name: Verify labextension
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion rust/perspective-python/build.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ if (build_sdist) {
prefix: `perspective_python-${version}`,
strict: true,
},
crate_files.concat(["PKG-INFO"])
crate_files.concat(["PKG-INFO", data_dir])
);
}

Expand Down
Loading