Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Classification Rules: add primary assessments to list table #6830

Closed
davidwatkins73 opened this issue Oct 26, 2023 · 4 comments
Closed
Assignees
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone

Comments

@davidwatkins73
Copy link
Member

Description

Similar to the approach taken for flows and licences.

Resourcing

We would like to add this request to the Waltz team's feature backlog

@davidwatkins73 davidwatkins73 added this to the todo : 1.55 milestone Oct 26, 2023
@davidwatkins73 davidwatkins73 self-assigned this Oct 29, 2023
@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Oct 29, 2023
@davidwatkins73
Copy link
Member Author

We recently added support for assessments on Flow Classification Rules, however these assessments can currently only be seen if the associated classification rule page is openend. It would be good to see these assessments from the list on the data types page. We should only show assessments flagged as primary in their definition.

Bonus - perhaps create a flow calssification index page which shows the table in more detail.

@davidwatkins73
Copy link
Member Author

Need to create a FlowClassificationRuleView object which looks something like:

flowClassificationRules()
assessmentDefinitions()
ratingSchemeItems()
assessmentRatings()

@davidwatkins73
Copy link
Member Author

image

@davidwatkins73
Copy link
Member Author

The colums are added dynamically based on primary assessments. Comments are shown as a tooltip. The rating can be searched over.

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Nov 13, 2023
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Nov 14, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.55.2, 1.55.2 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Development

No branches or pull requests

1 participant