Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation change (FIREBASE_CONFIG options loading) #70

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Documentation change (FIREBASE_CONFIG options loading) #70

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31bcfc9
Release Version 2.4.0 (#69)
avishalom Jan 11, 2018
b4d053e
Merge branch 'master' into dev
avishalom Jan 11, 2018
d121547
Comment on NewApp describing getting the options from the env var
avishalom Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions firebase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,12 @@ func (a *App) InstanceID(ctx context.Context) (*iid.Client, error) {

// NewApp creates a new App from the provided config and client options.
//
// If the client options contain a valid credential (a service account file, a refresh token file or an
// oauth2.TokenSource) the App will be authenticated using that credential. Otherwise, NewApp attempts to
// authenticate the App with Google application default credentials.
// If the client options contain a valid credential (a service account file, a refresh token
// file or an oauth2.TokenSource) the App will be authenticated using that credential. Otherwise,
// NewApp attempts to authenticate the App with Google application default credentials.
// If `config` is nil, the SDK will attempt to load the config options from the
// `FIREBASE_CONFIG` environment variable. If the value in it starts with a `{` it is parsed as a
// JSON object, otherwise it is assumed to be the name of the JSON file containing the options.
func NewApp(ctx context.Context, config *Config, opts ...option.ClientOption) (*App, error) {
o := []option.ClientOption{option.WithScopes(firebaseScopes...)}
o = append(o, opts...)
Expand Down